Summary
A command injection vulnerability exists in OpenClaw’s Linux systemd unit generation path.
When rendering Environment= entries, attacker-controlled values are not rejected for CR/LF, and systemdEscapeArg() uses an incorrect whitespace-matching regex. This allows newline injection to break out of an Environment= line and inject standalone systemd directives (for example, ExecStartPre=). On service restart, the injected command is executed, resulting in local arbitrary command execution (local RCE) under the gateway service user.
Details
The issue is in src/daemon/systemd-unit.ts:
renderEnvLines(...) builds:
Environment=${systemdEscapeArg(${key}=${value})}
- No CR/LF validation is enforced for environment keys/values before writing unit lines.
systemdEscapeArg(...) uses:
/[\\s"\\\\]/
- In this regex,
\\s is interpreted as a literal backslash + s, not a whitespace character class.
As a result, whitespace detection/quoting behavior is incorrect.
Because systemd parses unit files line-by-line, a newline inside an environment value can inject an additional directive line. Example rendered output:
Environment=INJECT=ok
ExecStartPre=/bin/touch /tmp/oc15789_rce
At restart time, systemd executes ExecStartPre, enabling command execution.
Relevant code path/components involved in exploitation chain:
src/daemon/systemd-unit.ts
src/commands/daemon-install-helpers.ts
src/config/env-vars.ts
src/config/zod-schema.ts
Trigger conditions:
- Attacker can influence
config.env.vars (directly or indirectly).